centralize clock handling for pthread_cond_timedwait

PortAudio / portaudio

PortAudio is a cross-platform, open-source C language library for real-time audio input and output.

Other

1.39k stars 291 forks source link

Closed RossBencina closed 5 months ago

RossBencina commented 6 months ago

Ensure that the clock that is configured on the cond object is the one that is used to compute the wait deadline
Ensure that the most appropriate clock is selected on each platform based on availability CLOCK_BOOTTIME > CLOCK_MONOTONIC > CLOCK_REALTIME (on Mac use gettimeofday because other clock interfaces are either not available or broken).

Used directly or indirectly by pa_jack, pa_alsa, pa_asihpi

Resolves #795, #807.

RossBencina commented 6 months ago

@s09bQ5 I've pushed some changes, does this PR fix #795 for you now?

s09bQ5 commented 6 months ago

Looks good to me now.

RossBencina commented 5 months ago

Note we don't yet have confirmation that this PR resolves #870

RossBencina commented 5 months ago

Waiting for confirmation from @nodemand that this PR is the version that fixes #870 for them.

s09bQ5 commented 5 months ago

And I can confirm that it fixes #795. Using JACK works now.

RossBencina commented 5 months ago

No longer gated by #870 (turns out to be unrelated).