search

PortAudio / portaudio

PortAudio is a cross-platform, open-source C language library for real-time audio input and output.
Other
1.39k stars 291 forks source link

Add support for sndio #878

Closed brad0 closed 5 months ago

brad0 commented 6 months ago

This is based on current modifications to portaudio done in OpenBSD.

Closes: #220

philburk commented 6 months ago

@brad0 - Thanks for taking this on. This PR can replace #647

I notice that the yaml CI is not being run! I wonder why.

brad0 commented 6 months ago

@brad0 - Thanks for taking this on. This PR can replace #647

I notice that the yaml CI is not being run! I wonder why.

Yup. I am continuing off of #647 plus the few suggestions made that were left. I fixed for https://github.com/PortAudio/portaudio/commit/2839fbbc072907ebac43bcdc7a5320e221c1ee5f and a few other minor things.

My last push was to also re-generate the autoconf script since I noticed it was being used during CI without it's own regeneration. I see it wasn't update since Pulse was added either.

philburk commented 6 months ago

@brad0 - I really appreciate you taking this on. Ross and I were looking at old stale PRs and this one looked very close to being ready. Just a few tweaks and we will be able to add sndio support. Yay!

brad0 commented 6 months ago

@brad0 - I really appreciate you taking this on. Ross and I were looking at old stale PRs and this one looked very close to being ready. Just a few tweaks and we will be able to add sndio support. Yay!

Well I would like to help where I can to get this in. As I said in the other PR we have had a PA backend in our ports tree for 16 years. So it would be good to finally have something go upstream.

https://github.com/openbsd/ports/commits/master/audio/portaudio-svn/files/pa_sndio.c

brad0 commented 6 months ago

@philburk Is there anything else you would like to see changed?

brad0 commented 5 months ago

@philburk Ping.

brad0 commented 5 months ago

I don't want to stand in the way of merging this, but here are a few variable namings that would be nice to clean up.

I don't mind making changes. I just need specific feedback.

RossBencina commented 5 months ago

Thanks @brad0. We're keen to accept any fixes, updates or cleanup as they become available.

brad0 commented 5 months ago

Thanks @brad0. We're keen to accept any fixes, updates or cleanup as they become available.

Thank you. If anything does come up I'll make sure to submit any such changes.