search

PortAudio / portaudio

PortAudio is a cross-platform, open-source C language library for real-time audio input and output.
Other
1.37k stars 286 forks source link

CMake regression?: default for PA_BUILD_SHARED_LIBS flipped from ON to OFF #918

Open RossBencina opened 1 month ago

RossBencina commented 1 month ago

Regarding PR #765 ("Remove usage of global BUILD_SHARED_LIBS variable" by @bheisch, merged April 1, 2023), @dechamps wrote:

FYI it looks like this patch caused the default for PA_BUILD_SHARED_LIBS to flip from ON to OFF, which surprised me - I ended up accidentally releasing a version of my project with PortAudio statically linked instead of bundling it as a separate DLL. (See https://github.com/dechamps/FlexASIO/commit/42e683b14b1e6398d4ceb5d4558b0d6da03ad73e.) Thankfully that's benign in my case, but it might not be for others. Was the change of default value intended?

RossBencina commented 1 month ago

Was the change of default value intended?

Not sure. But was it a change of the default value, or a reversion to the old default behavior that was in place prior to @Be-ing's big refactor?

syntaro commented 1 week ago

well, Im using static Library for My dynamic library.

MXLIB02.dll -> using Portaudio static link.