search

PortAudio / portaudio

PortAudio is a cross-platform, open-source C language library for real-time audio input and output.
Other
1.45k stars 303 forks source link

Fixes failure with configuration portaudiocpp with cmake (issue #939) #936

Closed donarturo11 closed 4 days ago

donarturo11 commented 3 months ago

This commit fixes error "PortAudio_FOUND but not target PortAudio::portaudio" thrown because of uncosistent cases. After this commit library PortAudio::PortAudio is found with no problems.

RossBencina commented 3 months ago

I assume that this bug is not triggered all the time or our CI would fail. Could you please file a separate issue describing the bug and how to reproduce it?

donarturo11 commented 2 months ago

I just filed an issue #939 .

RossBencina commented 1 month ago

As discussed at #939 this is not the correct fix. The correct fix is to undo the PortAudio CMakeLists.txt file to change the names back to portaudio. A relevant part of the discussion is the following:

https://github.com/PortAudio/portaudio/commit/242a0241f69bd359b692004f3974ce39ec5137fd#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR12

old: add_library(portaudio:

https://github.com/PortAudio/portaudio/commit/242a0241f69bd359b692004f3974ce39ec5137fd#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL374

old: add_library(portaudio_static:

https://github.com/PortAudio/portaudio/commit/242a0241f69bd359b692004f3974ce39ec5137fd#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL383

new: add_library(PortAudio:

https://github.com/PortAudio/portaudio/commit/242a0241f69bd359b692004f3974ce39ec5137fd#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR12