The cmake file should be installed in CMAKE_INSTALL_LIBDIR

PortMidi / portmidi

portmidi is a cross-platform MIDI input/output library

Other

116 stars 31 forks source link

The cmake file should be installed in CMAKE_INSTALL_LIBDIR #10

Closed cryptomilk closed 2 years ago

cryptomilk commented 2 years ago

https://github.com/PortMidi/portmidi/blob/587043f211b03205e3e2b9ef5dbd9efd19324f81/CMakeLists.txt#L125

The cmake files should be installed in ${CMAKE_INSTALL_LIBDIR} to take /usr/lib64 into account!

rbdannenberg commented 2 years ago

Are you saying the line should be set(PORTMIDI_INSTALL_CMAKEDIR ${CMAKE_INSTALL_LIBDIR}) ? If so, would it be even better to remove the set command and just replace occurrences of PORTMIDI_INSTALL_CMAKEDIR with CMAKE_INSTALL_LIBDIR? That would just be in DESTINATION and INSTALL_DESTINATION options (lines 130, 135, 146). Maybe this would even be the default for DESTINATION, in which case could the DESTINATION and/or INSTALL_DESTINATION options be removed?