PortMidi / portmidi

portmidi is a cross-platform MIDI input/output library
Other
116 stars 31 forks source link

Fix typo in comment #28

Closed ryandesign closed 2 years ago

ryandesign commented 2 years ago

It was me. I don't use Makefile.osx but others evidently use it. (Homebrew does; don't know why.) Not wanting to be the one to decide to remove it, I wanted to submit a fix for this typo, and may submit a fix to install the pkg-config file as well.

rbdannenberg commented 2 years ago

I started a discussion on Homebrew, so we'll see if anyone answers. If you submit a "fix to install the pkg-config file" it should also add a discussion of why anyone would use Makefile.osx and what it does. If it does nothing different from cmake, then it should be replace by a simple invocation of cmake, make, etc. Cmake already has a bunch of install code that I don't understand (nor do I really want to), which is OK as long as it's there because someone wants it bad enough to write it, use it, and fix it. On the other hand, Makefile.osx seems to be a left-over from many years ago, and probably is only used by Homebrew because it was there by mistake. If it's a mistake, let's don't propagate it.

rbdannenberg commented 2 years ago

As soon as I pressed "Comment," I had second thoughts: I really appreciate your efforts and interest, so don't take it the wrong way!