search

PortMidi / portmidi

portmidi is a cross-platform MIDI input/output library
Other
130 stars 35 forks source link

update version number to (already released) 2.0.4 #47

Closed rohlem closed 1 year ago

rohlem commented 1 year ago

Hi, thank you for this useful library. I just built it from branch master, and when looking at the built files I saw that the version number (reflected in the .pc package-config file) is still "2.0.3", even though 2.0.4 was already released. (AFAIK dynamic libraries can also hold a version number somewhere for inspection, though I didn't check if CMake does this automatically.)

This PR updates the version number in CMakeLists.txt to 2.0.4. (A quick grep didn't find it anywhere else, but maybe I've missed it. The changelog file also doesn't have a corresponding entry yet, fyi.) Alternatively, you could also jump straight to 2.0.5 I guess, so that it's out of the way for the next release.

rbdannenberg commented 1 year ago

Thanks - I haven't maintained or used package stuff and always recommend building this small library from sources and linking it statically, but now that I know to look for it, I'll try to keep the package-config file version consistent with the release. There are a few changes coming that I need to test, so probably will update everything to 2.0.5. I'm traveling now, but heck, let's pull this change anyway right now since it's arguably both correct and harmless.