search

PortMidi / portmidi

portmidi is a cross-platform MIDI input/output library
Other
116 stars 31 forks source link

CMake: Search for Threads in the installed config. #49

Closed FtZPetruska closed 1 year ago

FtZPetruska commented 1 year ago

Attempting to consume PortMidi in CMake on platforms linking against Threads::Threads currently fails with the following error message:

The link interface of target "PortMidi::portmidi" contains:

  Threads::Threads

but the target was not found.

This is due to Threads not being searched in the installed Config file.

rbdannenberg commented 1 year ago

Thanks for the fix. I don't use, test, or maintain CMake configuration facilities, but I'm happy to have them there for others. Contributions and improvements in this area are especially appreciated.

FtZPetruska commented 1 year ago

Thank you for your comment.

I am confused as to why this PR was closed, are you planning on adding this change manually? Are there any changes you wanted for this PR?

The issue is that, as it stands, downstream users cannot use PortMidi in CMake out of the box (outside of Windows).

rbdannenberg commented 1 year ago

Sorry - I thought I hit the merge button. I think it's done now.