PortSwigger / BChecks

BChecks collection for Burp Suite Professional and Burp Suite Enterprise Edition
https://portswigger.net/burp/documentation/scanner/bchecks
GNU Lesser General Public License v3.0
635 stars 112 forks source link

CVE-2023-23752 Joomla! Webservice - Users,Passwords information disclosure #179

Closed opcod3r closed 8 months ago

opcod3r commented 9 months ago

BCheck Contributions

PortSwiggerWiener commented 9 months ago

Many thanks for your submission. It looks good. We just need to fix up that predicate I think.

opcod3r commented 9 months ago

Many thanks for your submission. It looks good. We just need to fix up that predicate I think.

Thanks!

How can i do that ? could you help me ? with this ?

PortSwiggerWiener commented 9 months ago

Absolutely! So if you attempt to validate your BCheck within Burp then you should see a syntax error from this line:

if {check2.response.status_code} is "200" and "\"type\":\"application\"" and "\"password\":" in {check2.response.body} then

The reason for this is the first and clause is incomplete and needs a 'subject'. So if you want to check the response body from check2, then you could write:

if {check2.response.status_code} is "200" and "\"type\":\"application\"" in {check2.response.body} and "\"password\":" in {check2.response.body} then

I'm not entirely sure of your BCheck detection logic though so you make need to modify this.

Hope that helps!

Hannah-PortSwigger commented 9 months ago

Hi there!

Have you had a chance to review the feedback given?

Unfortunately, without this feedback implemented, we are not able to merge this pull request into the main repository.

If there's anything that we can help with, then please let us know.