search

PortSwigger / enterprise-helm-charts

Helm charts for BSEE Kubernetes installation.
Apache License 2.0
3 stars 4 forks source link

feat: support setting service type #3

Closed peter-svensson closed 1 month ago

peter-svensson commented 11 months ago

To support ingress controllers (like AWS ALB) that requires service.type to be NodePort.

H4CKS4F3 commented 8 months ago

@peter-svensson I like your suggestion, but I have proposed another solution (https://github.com/PortSwigger/enterprise-helm-charts/pull/4) which I hope provides even more flexibility depending on platform specific needs.

peter-svensson commented 8 months ago

@peter-svensson I like your suggestion, but I have proposed another solution (#4) which I hope provides even more flexibility depending on platform specific needs.

I have to problem with either solution, as long as it gets the job done and released 😊