PortSwigger / enterprise-helm-charts

Helm charts for BSEE Kubernetes installation.
Apache License 2.0
3 stars 4 forks source link

Support optional annotations and service type #4

Open H4CKS4F3 opened 8 months ago

H4CKS4F3 commented 8 months ago

The helm chart today is platform agnostic and establishes an ingress prerequisite. The proposed solution allows consumers to optionally define platform specific needs (annotations and service type). When omitted, the service will deploy exactly as it does today. When present, annotations and/or service type can be defined and controlled by the consumer.

This can allow for AWS and Azure deployments like so: values.yaml example for AWS:

services:
  webServer:
    type: ClusterIP

values.yaml example for Azure:

services:
  webServer:
    annotations:
      service.beta.kubernetes.io/azure-load-balancer-internal: "true"
    type: LoadBalancer

Since these are optional, this is backwards compatible.