search

Portable-Network-Archive / liblzma-rs

Bindings to liblzma in Rust (xz streams in Rust)
Apache License 2.0
12 stars 5 forks source link

tokio-io is deprecated #118

Open xbjfk opened 1 month ago

xbjfk commented 1 month ago

Hello, I was beginning to fork xz2 as well, until I came across this crate, thanks for maintaining it!

According to its docs, it has been deprecated in favor of tokio::io. I tried doing this and it made it seemed to be a non trivial migration, so it might be worth removing tokio entirely, like flate2-rs did: https://github.com/rust-lang/flate2-rs/pull/292, as well as https://github.com/alexcrichton/bzip2-rs/pull/89 and https://github.com/alexcrichton/xz2-rs/pull/109.

It seems the recommended approach is the async-compression crate, which unfortunately uses xz2 still, but I have made a PR: https://github.com/Nullus157/async-compression/pull/288.

Thanks!

ChanTsune commented 1 month ago

Hello @xbjfk !

Thank you for your message and suggestions. I will review the deprecation notice and consider the migration challenges.

Thanks again!