search

PortableApps / Toucan

sync, backup and secure, all in one place
http://portableapps.com/apps/utilities/toucan
GNU General Public License v2.0
126 stars 23 forks source link

Blank or Empty Folders #26

Closed blisstik closed 4 years ago

blisstik commented 4 years ago

Using the latest 3.1.7, I have an empty folder in Source that is read only, I run sync and it creates the folder on Destination. That's good.

I run it again. I expect there should be nothing to be done but now it deletes the empty read only folder in the Destination. Not good.

I need a way to sync 100%, including blank folders. Please advise.

alex-ter commented 4 years ago

So this is actually done explicitly, here. I don't see any comments and the code pre-dates my involvement with Toucan.

@sjlamerton, if you're still around and willing - could you please shed some light onto that logic? Personally, I too would expect it to just sync the empty folder and leave it alone, but I guess you had your reasons?

alex-ter commented 4 years ago

@blisstik, just to make sure - you are using the Mirror mode, right?

alex-ter commented 4 years ago

Okay, so given that Steve is probably away/isn't interested any more and the logic in that piece of code doesn't make sense to me after staring at it and experimenting (also with include/excludes) for good couple of hours, I think we can simply remove it.

However I'm not fully sure there aren't any side effects - so here's the test version. I don't use Sync mode at all, so can't fully test it by myself. BTW, if that works for you - I'd recommend you to switch to FreeFileSync, works like a charm for me and is actively developed.

To make it easier to test - just temporarily replace your current Toucan binary. As there are no other changes except the differential backup bug, which shouldn't affect you, this file is fully compatible with your current rules/variables/jobs files.

However it's always wise to create a backup copy of your full Portableapps setup just in case.

Specifically:

  1. Rename <your portableapps install dir>\PortableApps\Toucan\App\Toucan\toucan.exe to toucan.exe.orig
  2. Unpack the attached zip and copy toucan.exe into the same dir
  3. Run Toucan and execute your test scenarios

If that works for you, I'll put this in and make a release.

toucan.zip

SHA256 of toucan.zip: 902193808D4B86F9B2DDE2C9E58FD5A45E78EBFC8944D5ED85688DB4D4DF7AD1

alex-ter commented 4 years ago

@blisstik, is this still actual?

alex-ter commented 4 years ago

Closing for no response and ambiguous situation. If this is still a problem for you or anyone else reading this - please chime in and test out the program I attached earlier (make sure to backup your normal environment just in case)