search

PortableApps / Toucan

sync, backup and secure, all in one place
http://portableapps.com/apps/utilities/toucan
GNU General Public License v2.0
126 stars 23 forks source link

Differential backup mode adds a space at end of base file name #28

Closed captgeoff closed 4 years ago

captgeoff commented 4 years ago

Updated from 3.1.5 to 3.1.7 today. Tried to use a differential backup routine that worked in 3.1.5, but the program kept recreating the BaseFile.7z file, rather than adding a differential file.

Reinstalled 3.1.5 and ran the same routine. I ended up with a second BaseFile.7z in the same folder, which shouldn't be possible. On further investigation there is a space after the z in the version created by 3.1.7, so I assume it is not recognized as an archive when the differential routine goes looking for it.

The differential routine does work if a BaseFile.7z exists from an earlier copy of Toucan. But if you remove that copy, the process simply creates a new BaseFile.7z each time.

2019-11-10_18-26-42

alex-ter commented 4 years ago

Confirmed, thanks for reporting. I don't see anything explicit there, but will investigate further. There generally weren't any changes around that piece since 3.1.5, but we'll see when the root cause is found.

alex-ter commented 4 years ago

Just re-checked on 3.1.5 and it actually behaves the same, there's a space after 7z in the base file name. That confirms my previous comment regarding no changes around that piece of logic, nevertheless that's still a bug that must be fixed.

alex-ter commented 4 years ago

Okay, found it - looks like a typo that was there for quite a while (like "years"), the fix is on the way.