Portalum / Portalum.Zvt

A .NET Zvt Library for Payment Terminals (C#)
MIT License
88 stars 36 forks source link

Issue in Handling Terminal Responses #10

Closed SRouven closed 2 years ago

SRouven commented 2 years ago

Hello,

first of all, great project. Vielen Dank, es war für mich auch der Anstoß hier wirklich auch mal aktiv teil zu nehmen :)

I get issues, when working with ingenico PT´s over TCP. I´m mainly working with the Desk/3500 and Link/2500. When i call the registration, in most of my calls i´m getting an error and get problems in further communication. This also happens with the "Portalum ZVT ControlPanel".

In ZvtCommunication.ProcessDataReceived, there is no handling for a Buffer that contains the ACK (80-00-00) AND a following Completion. The Buffer that is recieved, i my cases, contains the ACK and Completiondata (22 byte long). But this can not be identified as an ACK in ZvtCommunication.SendCommandAsync (l. 121) and does never get processed by a recievehandler.

Register

I surely can provide you with more information, if needed.

tinohager commented 2 years ago

Thanks for the description I will get back to you in the next few days

tinohager commented 2 years ago

Hi can you check this version? https://github.com/Portalum/Portalum.Zvt/tree/fix/data-fragmentation

tinohager commented 2 years ago

Were they able to review my changes?

SRouven commented 2 years ago

I´m going to. I´m a little short in time, atm.

SRouven commented 2 years ago

HI, i checked the changes and don't have this issue anymore.