Portalum / Portalum.Zvt

A .NET Zvt Library for Payment Terminals (C#)
MIT License
88 stars 36 forks source link

Missing entries in IntermediateStatusRepository [Ingenico] #29

Closed SRouven closed 1 year ago

SRouven commented 1 year ago

NuGet Package Version

No response

Payment service provider

Secupay

Payment terminal

Ingenico Link 2500

Communication Logs

communication-export-2023-37-13-01-37-59.json.log

More information

For Ingenico terminals the IntermediateStateRepository is missing the entries 0xA0 to 0xA5. (Line 155 in the logs and "Timestamp": "2023-01-13T13:14:20.9553244+01:00")

Looks like Ingenico expanded this on its own. Documented here (p.82f) : https://cdn.ingenico.com/binaries/content/assets/germany-smart-terminals/ersatz-und-zuberhorteile/--3.x--schnittstellendoc/a32.de_zvt_ecr_interface_en_v1.3.41-customer.pdf

I'm not sure if you want to take that into account, but i´ll have to add this and wanted to let you know.

Best regards

tinohager commented 1 year ago

I think we only need a own IIntermediateStatusRepository for Ingenico with the additional codes. Or have I missed a case?

It also could build on the EnglishIntermediateStatusRepository class and just add additional code to the dictionary

SRouven commented 1 year ago

Those codes (A0-A5) are not in use, officially. So, for now, i wouldn´t mind, if they are simply added, to the existing repositories. This would avoid having to worry about additional configuration.

tinohager commented 1 year ago

However, this way the project would no longer meet the official standard of ZVT. So I would recommend to go the way over an own configuration to not run into problems in the future. The area AX is not reserved in the official documentation for own codes.

SRouven commented 1 year ago

That's legit.

SRouven commented 1 year ago

Problem solved, thank you.