[Fix] Azure & AWS key details should have `aws`, `azure` at the beginning

Portkey-AI / portkey-node-sdk

Build reliable, secure, and production-ready AI apps easily.

https://portkey.ai/docs

22 stars 8 forks source link

Closed vrushankportkey closed 4 months ago

VisargD commented 5 months ago

Hey @vrushankportkey - aws details already expects aws in the name. These are the params that you can use for AWS Bedrock in the config:

aws_secret_access_key
aws_access_key_id
aws_region

But as pointed out in this issue, azure params needs to be streamlined. These are the params that you can use for Azure in the config:

resource_name
deployment_id
api_version

These should be changed to:

azure_resource_name
azure_deployment_id
azure_api_version

vrushankportkey commented 5 months ago

Correct, but for TypeScript these will throw type errors right?