Portkey-AI / portkey-node-sdk

Build reliable, secure, and production-ready AI apps easily.
https://portkey.ai/docs
22 stars 8 forks source link

Remove unused locals (to fix Typescript noUnusedLocals problem) #96

Closed davidfant closed 1 month ago

davidfant commented 3 months ago

Title: Remove unused locals (to fix Typescript noUnusedLocals problem)

Description: This PR removes some unused variables that cause TS to complain

Motivation: For some reason I can't explain I'm getting these Typescript issues after having installed portkey. I have compilerOptions.skipLibCheck = true and exclude: ["node_modules"] in my tsconfig but it still happens. Even Claude Sonnet and GPT-4o are confused about why this is happening. Anyway, I figured I might as well contribute and improve the library rather than just applying a local patch

../node_modules/portkey-ai/dist/src/baseClient.ts:190:25 - error TS6133: 'path' is declared but its value is never read.

190         const { method, path, query, headers: headers = {}, body } = opts;
                            ~~~~

../node_modules/portkey-ai/dist/src/baseClient.ts:190:31 - error TS6133: 'query' is declared but its value is never read.

190         const { method, path, query, headers: headers = {}, body } = opts;
                                  ~~~~~

../node_modules/portkey-ai/dist/src/baseClient.ts:190:47 - error TS6133: 'headers' is declared but its value is never read.

190         const { method, path, query, headers: headers = {}, body } = opts;
                                                  ~~~~~~~

../node_modules/portkey-ai/dist/src/streaming.ts:69:7 - error TS6133: 'done' is declared but its value is never read.

69   let done = false;
         ~~~~

[9:27:41 PM] Found 4 errors. Watching for file changes.
vrushankportkey commented 3 months ago

Thank you so much for the PR, @davidfant!