search

Portponky / better-terrain

Terrain plugin for Godot 4
The Unlicense
509 stars 24 forks source link

C# wrapper warning CS8632 #59

Closed Go-Ba closed 9 months ago

Go-Ba commented 10 months ago

I'm getting warnings for BetterTerrain.cs CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.

image

because you've used ? on things that are already nullable by default like Array<int>? categories = null where Array<int> categories = null works fine.

this technically is a thing you can do with Nullable contexts to make these reference types not nullable by default but there's none in the file.

I'm just wondering if I'm missing any context before just removing the ? from the reference types or if maybe you just weren't familiar with these types already being nullable by default and the ? being unnecessary.

Portponky commented 10 months ago

I'm not very familiar with C#, and some of the wrapper was provided by a contributor. If you can improve it, please open a PR with the changes. Otherwise, I can download the dot net godot and attempt it myself.

Portponky commented 9 months ago

Fixed by PR, asset library version was updated. Should be all fixed.