Portponky / better-terrain

Terrain plugin for Godot 4
The Unlicense
433 stars 21 forks source link

Changes to terrain are not being saved (4.3) #92

Open timoohr opened 6 days ago

timoohr commented 6 days ago

First of all let me thank you for this amazing plugin. It's such a massive improvement over the default implementation that I think they should just replace it with yours :)

That said, there seems to be a bit of an issue when it comes to saving the terrain data. I'm using the tile-map-layer branch with Godot 4.3.beta2 and the new TileMapLayer node. Went ahead and set up a few dozen terrains yesterday, but after opening the project again today most of them seem to be gone, which, needless to say, was a bit of a bummer.

After digging around a bit, it does seem indeed that Godot seems pretty reluctant to save any changes made to the terrains to the tileset file when pressing CTRL+S. Usually requires changing some other settings in the tileset (like margins or something) to get it to do so.

the-old-one commented 3 days ago

I've noticed that as well in 4.3 and I'm not sure if it's an issue of Godot or the plugin. For now the TileSet itself has a Save option in the menu which works reliably.

Screenshot 2024-07-04 190813
Portponky commented 10 hours ago

Hi, yes, this is a Godot bug or quirk. I've not been able to narrow down the cause, but it's something to do with setting metadata on a TileData object in a resource. Sometimes it marks it as a change that can be saved, other times it does not.