Portree-Kid / flightgear-airports

GNU General Public License v3.0
6 stars 1 forks source link

V 0.0.26 - Frequencies rounded to nearest integer when saved #100

Open LGBudd opened 3 years ago

LGBudd commented 3 years ago

All frequencies are rounded to nearest integer after a Save. This has not been the case in previous release AFAIK.

sfrsfrsfr commented 3 years ago

Hi,

i'd say this is not a bug. Frequencies for groundnets (and for all airports, see $FG_DATA/Airports/apt.dat.gz) are not specified as floats but as integers. E.g. at LSZH ATIS frequency is 128.52 MHz but is stored as 12852.

LGBudd, pls verify and mark as closed if appropriate.

LGBudd commented 3 years ago

sfrsfrsfr, you are correct. Frequencies in Taxidraw were to be entered without the decimal point, too. I simply forgot it.

I would argue, however, that it would be good to either "allow" entry of a decimal but not pass it on to the xml OR provide a message to the user to enter frequencies without decimal points. I have forgotten this more than once (just as I did this time), even though I've done many groundnets. It does not follow the data entry method of other apps/programs I'm familiar with. Could this be considered an "enhancement?"