search

Portree-Kid / flightgear-airports

GNU General Public License v3.0
6 stars 1 forks source link

0.0.32: More Feedback from Travis/Github on failed builds. #136

Open sfrsfrsfr opened 3 years ago

sfrsfrsfr commented 3 years ago

When the groundnet upload for EDTY (see #135) failed no error message was shown in the GUI. For successful uploads it does show sth like 'Upload successful'.

Portree-Kid commented 3 years ago

Practically impossible. Your upload was successful but failed the checks. That is asynchronous and I’m not sure how to get the results.

sfrsfrsfr commented 3 years ago

I see. But if some checks failed fga is aware of it, just not the exact reason i think. So how about showing a message like 'Upload succeed but some checks failed. For details reupload manually at http://groundweb.azurewebsites.net/'.

Portree-Kid commented 3 years ago

No FGA isn't aware of it. The checker is run by travis https://travis-ci.org/github/terrasync/main/builds/ the result is sent to github. FGA doesn't "know" about GIT. One of the longterm goals was to make it aware of it. But that's like next year. If anyone feels up to it. https://docs.github.com/en/rest the BRANCH could be in the response from groundweb

sfrsfrsfr commented 3 years ago

ok, feel free to close this issue then.