v0.20 Nodes move on save as Lat Lon are persisted in XML rounded to 3 decimals instead of 6.

Portree-Kid / flightgear-airports

GNU General Public License v3.0

6 stars 1 forks source link

v0.20 Nodes move on save as Lat Lon are persisted in XML rounded to 3 decimals instead of 6. #75

Closed BecOzIcan closed 3 years ago

BecOzIcan commented 4 years ago

ENTERED in FGA

EXPECTED in XML

OBSERVED in XML

SAVE / EDIT

Point has moved

Previous bug was about the UI rendering #18 but it looks like the data is not persisted properly. Is there a limitation in hte XML scheme or in traffic manager to read the XML with 6 decimals ?

BecOzIcan commented 4 years ago

I will have a quick chat to James to verify if 6 digits are likely to cause an issue downstream, in traffic manager

BecOzIcan commented 4 years ago

Confirmed with James that traffic manager would accept 6 decimals with no impact

Portree-Kid commented 4 years ago

Actually we have D.d with 6 decimals which would be 5 in D M.m. https://wiki.openstreetmap.org/wiki/Precision_of_coordinates

BecOzIcan commented 4 years ago

Honestly struggling now

Precision of values we enter in FGA in Digtal Degrees with 6 decimals (DD.dddddd) is 0.11 meters from the OSM doco. The only reference to Decimal Minutes I see is the below table which tells me I need only 4 decimals in the Decimal Minutes D MM format to get a similar precision of 0.18 meters.

I have just ran an extra test on my sheet which confirms the same ie 4 decimals should be enough

I guess at the end of the day the acid test for us is "the value I enter in FGA is the one I get back for the same point after I save and reload".

wkitty42 commented 4 years ago

I guess at the end of the day the acid test for us is "the value I enter in FGA is the one I get back for the same point after I save and reload".

this!

yes, i hate it when i set a line point somewhere, save, and edit and the node has moved... i do a lot of edit, save, edit to be sure what i've deleted or added (or when i've split a line) gets saved before i do anything else to that line or node...

BecOzIcan commented 4 years ago

I am happy to let go on some UX/UI requirements if you can get this one across the MVP. We have suffered enough from the issue in Taxidraw to not want to repeat it in FGA. Name your price !

sfrsfrsfr commented 3 years ago

i don't have much to add except a 'me too'.

Portree-Kid commented 3 years ago

Fixed in 0.27

sfrsfrsfr commented 3 years ago

that's simply great!

BecOzIcan commented 3 years ago

Awesome news ! Feels like a second Christmas morning. Thanks a lot Keith. Looking forward to this release