search

Portree-Kid / flightgear-airports

GNU General Public License v3.0
6 stars 1 forks source link

0.0.24: Groundnet version should be an integer, not a string #95

Closed sfrsfrsfr closed 3 years ago

sfrsfrsfr commented 3 years ago

i noticed the exported groundnet XML files contain this line:

<version>Sun, 30 Aug 2020 19:35:02 GMT by FlightgearAirports</version>

But flightgear assumes <version> is an integer, not a string. See flightgear/src/AIModel/AIFlightPlanCreate.cxx:

if (gn->getVersion() == 1) { runwayNode = gn->findNearestNodeOnRunway(lastWptPos); } else { runwayNode = gn->findNearestNode(lastWptPos); }

Although it doesn't seem to be an issue right now i think the fga version string should better be put in a comment instead. Addtionally it doesn't even mention the version of fga used :)

What about already uploaded/distributed groundnet files?

Portree-Kid commented 3 years ago

This could be the cause for some erratic behaviour. I'll check what the correct file version should be

Portree-Kid commented 3 years ago

Fixed in 0.0.26