search

PortsMaster / PortMaster-New

New PortMaster repo
https://www.portmaster.games
MIT License
46 stars 46 forks source link

Remove errant & from TMNTShreddersRevenge.sh #465

Closed konomikitten closed 3 weeks ago

konomikitten commented 3 weeks ago

This script fails to run due to an errant &, remove it and fix the script.

sirchia commented 3 weeks ago

The '|&' notation is not erroneous, but a shorthand for '2>&1 |' (redirect stderr to stdout and pipe both to following command) that is unfortunately not widely supported in all shells. The suggested resolution in this PR misses any output in stderr.

Instead I propose this PR that resolves all occurrences in all ports currently present: https://github.com/PortsMaster/PortMaster-New/pull/466

konomikitten commented 3 weeks ago

Closing this pull request in favor of #466.

sirchia commented 2 weeks ago

Please consider testing the proposed changes in #466 on your device and mark my PR as reviewed in GitHub to possibly expedite acceptance of the changes in the main branch.