search

PortsMaster / PortMaster-New

New PortMaster repo
https://www.portmaster.games
MIT License
46 stars 46 forks source link

Replaced all '|&' occurrances with more widely supported '2>&1 |' #466

Closed sirchia closed 2 weeks ago

sirchia commented 3 weeks ago

Some handhelds that don't have a 'real' bash shell but some other sh compatible shell don't support the shorthand notation of '|&'.

Change to the equivalent but more widely supported '2>&1 |' notation.

JohnnyonFlame commented 2 weeks ago

Sure, but like, what device? Is this OFW/CFW? I would focus on providing proper bash instead if you control the firmware.

[8:04 AM]kloptops: muOS, TrimUI, Knulli all use busybox ash.

ugh, that means a lot of devices, it's a good change then, I'll keep this in mind.

konomikitten commented 2 weeks ago

I'm pretty well versed in shell coding, I've looked over all the changed files and they look good to me. While I'd like to test the changes I don't have a device I was making the earlier commit to fix things for someone else. I also don't own most of the games involved.