Posandu / svelte-ripple-action

Svelte Ripple Action
https://ripple.posandu.com/
MIT License
59 stars 0 forks source link

Not working across SvelteKit page changes #3

Closed OfficialCRUGG closed 10 months ago

OfficialCRUGG commented 1 year ago

The ripple effect seems to not work across page changes with SvelteKit. When using it on a SvelteKit link, the ripple just plays in the top left of the screen, regardless of where the button is.

Posandu commented 1 year ago

Hey @OfficialCRUGG can you provide an example where it happens? I can't seem to reproduce it on https://www.sveltelab.dev/mo9p9we0o1vdrd3

You also can try adding the class ripple-effect to the element and see if it happens

NatumanyaGuy commented 11 months ago

Hey there, Got the same issue with the ripple behavior on transition from different Sveltekit routes. Managed to replicate it on a SvelteLab project

Posandu commented 11 months ago

Oh, Thanks @NatumanyaGuy. I'll look into it. In the meantime, you can add the class ripple-effect to those affecting elements.

NatumanyaGuy commented 11 months ago

Thanks a lot.

Posandu commented 10 months ago

Hey, @OfficialCRUGG and @NatumanyaGuy I just published version 1.0.5 which fixes the issue. Previously it was adding a class which was causing the issue. Now, it adds a custom attribute instead.

NatumanyaGuy commented 10 months ago

Thanks a lot!