search

PoshCode / ModuleBuilder

A PowerShell Module to help scripters write, version, sign, package, and publish.
MIT License
445 stars 54 forks source link

Add new line before the content of each script file (fixes #126) #127

Closed johlju closed 7 months ago

johlju commented 8 months ago

This PR will resolve issue #126 by adding a new line before the content of each script file.

johlju commented 8 months ago

@Jaykul I run the unit test that I modified but expected the pipeline would run all tests, but it doesn't happen?

EDIT: I run all tests locally and they pass.

johlju commented 8 months ago

@Jaykul gentle reminder to see if you can get some time to review and merge this?

Jaykul commented 7 months ago

There. I fixed the build ... in your PR ... so uhm. That's a thing now.

johlju commented 7 months ago

Yes that is very convenient since it is default enabled on new PRs and opt-out for contributors. I use it often as a maintainer, but mostly to resolve conflicts. Even easier when you can tap . when looking at a PR in GitHub and be taken to into VS Code on the web for the review and making code changes. Very elegant. 😊

Thanks for fixing the PR and merging it. Looking forward to a release (unless it already happened) 😊