search

PoshCode / ModuleBuilder

A PowerShell Module to help scripters write, version, sign, package, and publish.
MIT License
447 stars 53 forks source link

Use alphabetical order #69

Closed bravo-kernel closed 5 years ago

bravo-kernel commented 5 years ago

I hope I am not driving you crazy and hope even more that I am not misinterpreting anything here but this fail is exactly what scares me the most about using those remote pipeline templates. I do see the value of templating but I also see a lot of danger in making the CI not 100% predictable in the one place where that counts most, caused by external dependencies, out of direct control.

Normally a fix in this PR would do the trick to get things all green again. How does that work now?

  1. make a PR to the remote repo holding the template?
  2. ask for a re-trigger of this PR (or push some dummy change)?
  3. repeat steps 1 and 2 until things work as a whole again?

To be fair, I understand the templates are on your own remote repo so it is less of an issue but would you be as comfortable using somebody else's repo for your builds? Just curious, not trying to alienate you here, just going for the polished gem (even though I must admit that I am a bit frustrated not being able to "just fix this" as normally would be the case).

Jaykul commented 5 years ago

Yeah. I definitely need to see this build succeeding more to be happy, and I apologize I'm letting things sit around.

bravo-kernel commented 5 years ago

No problem, this is all open source so no obligations anyway. I have converted my multi-stage pipeline matrix to templates as well btw. Works great, I just chose to place (and keep) them in the same repo to make sure contributors can fix the whole cylce if need be.