PoshCode / ModuleBuilder

A PowerShell Module to help scripters write, version, sign, package, and publish.
MIT License
445 stars 54 forks source link

Version 1.5.2 cannot read the manifest file #87

Closed bravo-kernel closed 4 years ago

bravo-kernel commented 4 years ago

After upgrading ModuleBuilder to 1.5.2 my build-phase is broken. It looks like the manifest file cannot be found. After pinning 1.0.0 the problem is gone.

Since there are no messages/warnings in the log, any pointers on what could be amiss here?

Info

mattmcnabb commented 4 years ago

@bravo-kernel I just ran into the same issue and at least in my case, the problem is with the -Path parameter of Build-Module. I found that this is now called -ModuleManifest. If you're calling -Path try changing to -ModuleManifest to see if that fixes it.

If that works I think there are some documentation problems that need to be addressed.

EDIT: I clearly don't understand how this works, as the parameter -SourcePath appears to have aliases of Path and ModuleManifest.

bravo-kernel commented 4 years ago

@mattmcnabb thanks for responding, I just gave ModuleManifest a try but unfortunately with the same result. Let's hope someone can make some sense out of this.

image

Jaykul commented 4 years ago

You misunderstood. If you put ModuleManifest in your Build.psd1 (instead of Path), then it works.

This is clearly a bug related to #49 and the code I wrote to parse build.psd1 and handle aliases. That parameter, in particular, was a real pain because it's always already set, but almost always needs to be overwritten anyway.

bravo-kernel commented 4 years ago

I can confirm that I indeed misunderstood. After updating Source/build.psd1 to use ModuleManifest instead of Path... ci is now happily building again.

bravo-kernel commented 4 years ago

@mattmcnabb sorry about that, you already gave me the solution ;)