`is_deleted` for `person_distinct_id`, fix a race condition - Githubissues

PostHog / plugin-server

Service to process and save PostHog events, supporting JS/TS plugins at that

https://posthog.com

8 stars 5 forks source link

`is_deleted` for `person_distinct_id`, fix a race condition #503

Closed macobo closed 3 years ago

macobo commented 3 years ago

This PR:

Fixes a race condition in plugin server causing wrong rows to appear in person_distinct_id table: https://github.com/PostHog/plugin-server/issues/502
Updates ingestion to use is_deleted column for person_distinct_id table instead of deleting rows
Fixes broken build due to new column in organization table

See companion PR for more context: https://github.com/PostHog/posthog/pull/5151 Related issue: https://github.com/PostHog/posthog/issues/4242

Note that:

Workflows got updated on the PR to point to open PR on posthog/ repo to make tests pass. Will revert just before merging

Checklist

[x] Updated Settings section in README.md, if settings are affected
[x] Jest tests