search

PostHog / plugin-server

Service to process and save PostHog events, supporting JS/TS plugins at that
https://posthog.com
8 stars 5 forks source link

Be less eager to disable an erroring plugin #516

Closed Twixes closed 3 years ago

Twixes commented 3 years ago

Currently any non-RetryError error in a plugin causes it to be disabled. That's bad for data integrity – it creates a lot of opportunities for the plugin to be disabled and we also don't report that happening.

Before going with this drastic step, we should try retrying even if it's not a RetryError. This should apply to plugin loading, unloading, event processing, jobs, basically any operation with potential to disable the plugin.

This problem was brought up by a current user of our Snowflake Export Plugin.

neilkakkar commented 3 years ago

Makes sense, another user had this problem as well: https://posthogusers.slack.com/archives/G01JXEDAL22/p1627847768031300

neilkakkar commented 3 years ago

Prev discussion: https://github.com/PostHog/plugin-server/issues/471