Remove `id` from `ClickHousePersonDistinctId` interface

PostHog / plugin-server

Service to process and save PostHog events, supporting JS/TS plugins at that

https://posthog.com

8 stars 5 forks source link

Remove `id` from `ClickHousePersonDistinctId` interface #539

Closed Twixes closed 3 years ago

Twixes commented 3 years ago

Changes

Extension to #536 that fixes the remaining issue.

Twixes commented 3 years ago

Noo Yakko, this was actually failing too! LOL

yakkomajuri commented 3 years ago

hahaha sorry, feel free to edit my branch. CH + Kafka (1) is so flaky I didn't even look. Also my local machine is struggling to run these tests so I'm pushing and waiting, hence my rush to get this in lol

yakkomajuri commented 3 years ago

on a side note I really should dig into those tests