add `isIdentified` property and check on `identify()`

beradeep commented 2 months ago

:bulb: Motivation and Context

This change adds the is_identified property (absent earlier) to check user is identified or not (anonymous). This change also adds a fix to identify() to ensure that an "identify" event is captured if and only if the user isn't already identified (anonymous).

fix #136 & #108

:green_heart: How did you test it?

Added unit test to assert against duplicate "identify" captures
Added unit test to assert "identify" works as usual on reset
Verified that this change doesn't break existing tests

:pencil: Checklist

[x] I reviewed the submitted code.
[x] I added tests to verify the changes.
[ ] I updated the docs if needed.
[x] No breaking change or entry added to the changelog.

marandaneto commented 2 months ago

@beradeep would you pick up this PR again? just so I don't get to it as well, thanks.

beradeep commented 2 months ago

Yes, I'll pick it up. I think I should go with the solution you provided in a7bf27a.

beradeep commented 2 months ago

When should I turn isIdentifiedLoaded back to false? Inside PostHog.endSession()?

beradeep commented 2 months ago

@marandaneto Sorry, I closed this PR accidentally. I've created a new one #167.

PostHog / posthog-android