search

PostHog / posthog-go

Official PostHog Go library
MIT License
20 stars 17 forks source link

Support multiple cohorts in local evaluation #34

Closed zaynetro closed 6 months ago

zaynetro commented 6 months ago
  1. There's more than one cohort in the feature flag definition.

This restriction is annoying. Copying what NodeJS SDK does.

Ref: https://posthog.com/docs/feature-flags/local-evaluation

PS Sorry I couldn't reopen my old PR somehow :/

neilkakkar commented 6 months ago

This is excellent, thanks @zaynetro , will review shortly

zaynetro commented 6 months ago

Hi! Do you plan on merging this soonish? Is there something I can help with?

neilkakkar commented 6 months ago

Sorry was off sick with a bad cold, didn't write a proper note on the approval. I'm just going to test this version with cohorts with a real project, and merge when all still looks good!

Thanks again for doing this :)

neilkakkar commented 6 months ago

All good here :) - I found a separate issue where non-integer rollout percentages bork unmarshalling, but nothing related to this 👍

neilkakkar commented 6 months ago

Thanks @zaynetro for all your recent contributions. I'd love to send you a posthog merch code, could you send me an email at neil @ posthog . com ?