PostHog / posthog-ios

PostHog iOS SDK
https://posthog.com/docs/libraries/ios
MIT License
28 stars 37 forks source link

fix ISO8601 formatter to always use the 24h format #106

Closed marandaneto closed 4 months ago

marandaneto commented 4 months ago

:bulb: Motivation and Context

Closes https://github.com/PostHog/posthog-ios/issues/103

:green_heart: How did you test it?

:pencil: Checklist

marandaneto commented 4 months ago

@bddq are you able to test from a branch? the format was HH already and not hh so I believe it could be the default timezone and locale. I cannot change my emulator to 12h only for some reason, the settings are blocked.

github-actions[bot] commented 4 months ago
Fails
:no_entry_sign: Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Next" section. Make sure the entry includes this PR's number. Example:

## Next
- fix ISO8601 formatter to always use the 24h format ([#106](https://github.com/PostHog/posthog-ios/pull/106))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by :no_entry_sign: dangerJS against 3302e97e02e5cddcca83bee4682d2877658f6b6f