PostHog / posthog-ios

PostHog iOS SDK
https://posthog.com/docs/libraries/ios
MIT License
28 stars 37 forks source link

chore: silence shared warning for strict concurrency #129

Closed marandaneto closed 2 months ago

marandaneto commented 2 months ago

:bulb: Motivation and Context

Closes https://github.com/PostHog/posthog-ios/issues/127 Draft PR trying to silence all warnings for the SDK as well https://github.com/PostHog/posthog-ios/pull/128 That will likely require a iOS SDK v4 with major changes, but not worth for now until we are able to drop older iOS/Swift versions support and start using async/await, all sendable, etc. nonisolated(unsafe) would be better as well instead of the whole class but that requires Swift >= 5.10 sadly. Edit: nonisolated(unsafe) is possible using a compile directive and checking the Swift version

:green_heart: How did you test it?

:pencil: Checklist