search

PostHog / posthog-ios

PostHog iOS SDK
https://posthog.com/docs/libraries/ios
MIT License
35 stars 41 forks source link

MAJOR - Deleting Application Support Directory! #130

Closed nitrag closed 4 months ago

nitrag commented 4 months ago

Version

3.2.4

Steps to Reproduce

  1. Call PostHogSDK.shared.reset()

Expected Result

Only delete PostHog related data

Actual Result

PostHog wipes the entire directory!! Shame on you guys for doing this, we have valuable data in this directory.

https://github.com/PostHog/posthog-ios/blob/a12c3418f0f38511b8dc3d8cfb572681785ecf62/PostHog/PostHogStorage.swift#L17-L20

marandaneto commented 4 months ago

Hi @nitrag let me check this for you.

marandaneto commented 4 months ago

@nitrag I can confirm the bug, so sorry about that, we'll make sure this won't happen again. we'll cut a patch https://github.com/PostHog/posthog-ios/pull/132 just need to add some tests and make sure that there are no side effects, thanks for opening this.

marandaneto commented 4 months ago

Fixed by https://github.com/PostHog/posthog-ios/releases/tag/3.2.5

nitrag commented 4 months ago

Thank you for your quick attention to this!