PostHog / posthog-ios

PostHog iOS SDK
https://posthog.com/docs/libraries/ios
MIT License
32 stars 41 forks source link

Basic feature flag + Groups support #28

Closed EDsCODE closed 2 years ago

EDsCODE commented 2 years ago

What does this PR do?

Where should the reviewer start?

  1. Distinct id handling
  2. Group handlers
  3. Feature flag handlers

How should this be manually tested? TBD. Bundle and test in a local project?

What are the relevant tickets?

TODO:

EDsCODE commented 2 years ago

The distinct id - anonymous id handling here needs work

EDsCODE commented 2 years ago

Feature flag works. Groups don’t work for some reason. The call is being queued in the client but nothing is making it to the posthog instance

Groups work. Distinct_id wasn't being sent

EDsCODE commented 2 years ago

There's inconsistencies with the test suite. Even on master it seems tests will still fail. I'm suggesting the removal of the workflow for the time being

liyiy commented 2 years ago

Does it make sense to add example functionality usages like we've been doing in the server libraries with example.py for example to make this easier for testing?

EDsCODE commented 2 years ago

Added calls to the example directory projects