search

PostHog / posthog-ios

PostHog iOS SDK
https://posthog.com/docs/libraries/ios
MIT License
29 stars 37 forks source link

`$active_feature_flags` should filter non active flags #73

Closed marandaneto closed 9 months ago

marandaneto commented 9 months ago

What does this PR do? Similar to this one https://github.com/PostHog/posthog-android/pull/41 Closes https://github.com/PostHog/posthog-android/issues/40

Where should the reviewer start?

How should this be manually tested? there is no unit test at all for that, I will add in the new version of the iOS SDK, but for now this should be fine.

Any background context you want to provide? decide v3 returns all the feature flags and not only the active ones

What are the relevant tickets?

Screenshots or screencasts (if UI/UX change)

Questions:

marandaneto commented 9 months ago

A test or two would be nice, and give me confidence that the type conversion works as expected, but otherwise LGTM!

I made sure to run locally on an emulator, so it's fine, let me check if it's easy to set up a mock HTTP cal, etc.

neilkakkar commented 9 months ago

not a requirement! happy as long as it works, given you're going to revamp soon