PostHog / posthog-ios

PostHog iOS SDK
https://posthog.com/docs/libraries/ios
MIT License
32 stars 41 forks source link

Renamed some functions from utils #9

Closed serhii-lyshchenko closed 3 years ago

serhii-lyshchenko commented 3 years ago

What does this PR do? It renames some functions from utils.

Where should the reviewer start? It just renames few functions from utils, and replaces their name with new ones throughout the project.

How should this be manually tested? It shouldn't cause build errors when this package and https://github.com/segmentio/analytics-ios are using together.

Any background context you want to provide? It's impossible to use PostHog library together with Segment library on iOS. It happens because PostHog iOS package is based on Segment package, and they have duplicating function names which is causing failing of app build.

What are the relevant tickets? https://github.com/PostHog/posthog-react-native/issues/2

Screenshots or screencasts (if UI/UX change)

Questions:

mariusandra commented 3 years ago

Thanks @serhey-dev for this! Apologies for the wait, yet 1.2.3 is now out with the change. I'll update the RN repo next.