chore: add device model and replace device name

PostHog / posthog-js-lite

Reimplementation of posthog-js to be as light and modular as possible.

https://posthog.com/docs/libraries

MIT License

70 stars 36 forks source link

chore: add device model and replace device name #172

Closed marandaneto closed 9 months ago

marandaneto commented 9 months ago

Problem

Noticed by checking the most common devices dashboard template that RN used the wrong property for device model and name

Changes

Release info Sub-libraries affected

Bump level

[ ] Major
[ ] Minor
[x] Patch

Libraries affected

[ ] All of them
[ ] posthog-web
[ ] posthog-node
[x] posthog-react-native

Changelog notes

Added support for X

github-actions[bot] commented 9 months ago

Size Change: 0 B 🆕

Total Size: 0 B

_{compressed-size-action}

marandaneto commented 9 months ago

Code-wise no issues, but is this technically a breaking change? Not so much for the SDK but for the analytics data on the other end 🤔

yes, it is, but right now you cannot do analytics across different platforms anyway since the properties were set wrongly/differently depending on the SDK. maybe we could be more clear on the changelog instead? although it's a breaking change, it's also a bug fix, otherwise our dashboard templates is also broken.

marandaneto commented 9 months ago

the RN build command is not packing the uuidv7 dep so I have to fix that first.

marandaneto commented 9 months ago

close in favor of https://github.com/PostHog/posthog-js-lite/pull/185