PostHog / posthog-js-lite

Reimplementation of posthog-js to be as light and modular as possible.
https://posthog.com/docs/libraries
MIT License
69 stars 36 forks source link

fix: all sdkReplayConfig should have a default value #291

Closed marandaneto closed 1 month ago

marandaneto commented 1 month ago

Problem

https://posthog.com/questions/installing-session-replay-and-updating-posthog-crashes-the-app

Changes

Release info Sub-libraries affected

Bump level

Libraries affected

Changelog notes

github-actions[bot] commented 1 month ago

Size Change: +162 B (+0.15%)

Total Size: 106 kB

Filename Size Change
posthog-react-native/lib/posthog-react-native/src/posthog-rn.js 3.97 kB +162 B (+4.26%)
ℹ️ View Unchanged | Filename | Size | | :--- | :---: | | `posthog-node/lib/index.cjs.js` | 20 kB | | `posthog-node/lib/index.esm.js` | 20 kB | | `posthog-react-native/lib/posthog-core/src/eventemitter.js` | 1.08 kB | | `posthog-react-native/lib/posthog-core/src/index.js` | 9.72 kB | | `posthog-react-native/lib/posthog-core/src/lz-string.js` | 1.42 kB | | `posthog-react-native/lib/posthog-core/src/types.js` | 365 B | | `posthog-react-native/lib/posthog-core/src/utils.js` | 822 B | | `posthog-react-native/lib/posthog-core/src/vendor/uuidv7.js` | 2.04 kB | | `posthog-react-native/lib/posthog-react-native/index.js` | 485 B | | `posthog-react-native/lib/posthog-react-native/src/autocapture.js` | 1.78 kB | | `posthog-react-native/lib/posthog-react-native/src/frameworks/wix-navigation.js` | 651 B | | `posthog-react-native/lib/posthog-react-native/src/hooks/useFeatureFlag.js` | 437 B | | `posthog-react-native/lib/posthog-react-native/src/hooks/useFeatureFlags.js` | 362 B | | `posthog-react-native/lib/posthog-react-native/src/hooks/useLifecycleTracker.js` | 416 B | | `posthog-react-native/lib/posthog-react-native/src/hooks/useNavigationTracker.js` | 628 B | | `posthog-react-native/lib/posthog-react-native/src/hooks/usePostHog.js` | 249 B | | `posthog-react-native/lib/posthog-react-native/src/legacy.js` | 810 B | | `posthog-react-native/lib/posthog-react-native/src/native-deps.js` | 1.17 kB | | `posthog-react-native/lib/posthog-react-native/src/optional/OptionalAsyncStorage.js` | 183 B | | `posthog-react-native/lib/posthog-react-native/src/optional/OptionalExpoApplication.js` | 215 B | | `posthog-react-native/lib/posthog-react-native/src/optional/OptionalExpoDevice.js` | 211 B | | `posthog-react-native/lib/posthog-react-native/src/optional/OptionalExpoFileSystem.js` | 224 B | | `posthog-react-native/lib/posthog-react-native/src/optional/OptionalExpoLocalization.js` | 216 B | | `posthog-react-native/lib/posthog-react-native/src/optional/OptionalReactNativeDeviceInfo.js` | 220 B | | `posthog-react-native/lib/posthog-react-native/src/optional/OptionalReactNativeNavigation.js` | 218 B | | `posthog-react-native/lib/posthog-react-native/src/optional/OptionalReactNativeNavigationWix.js` | 222 B | | `posthog-react-native/lib/posthog-react-native/src/optional/OptionalSessionReplay.js` | 231 B | | `posthog-react-native/lib/posthog-react-native/src/PostHogContext.js` | 210 B | | `posthog-react-native/lib/posthog-react-native/src/PostHogProvider.js` | 1.49 kB | | `posthog-react-native/lib/posthog-react-native/src/storage.js` | 1.09 kB | | `posthog-react-native/lib/posthog-react-native/src/types.js` | 90 B | | `posthog-react-native/lib/posthog-react-native/src/version.js` | 123 B | | `posthog-web/lib/index.cjs.js` | 17.1 kB | | `posthog-web/lib/index.esm.js` | 17.1 kB |

compressed-size-action

marandaneto commented 1 month ago

Not fluent in js but I think we could also use the spread operator to merge defaults with params.

LGTM though

Yes, the spread operator would merge but it'd have the wrong result if someone passes eg maskAllTextInputs: undefined, the undefined would have precedence over the default value, with the current form, no, the default value would have precedence.

ioannisj commented 1 month ago

Yeah, super valid thinking. Awesome :)