search

PostHog / posthog-js

Send usage data from your web app or site to PostHog, with autocapture.
https://posthog.com/docs/libraries/js
Other
299 stars 125 forks source link

feat: add a `page` function #1397

Closed anirudh24seven closed 2 weeks ago

anirudh24seven commented 2 months ago

Changes

Adding a new page function as requested in https://github.com/PostHog/posthog/issues/635 ...

Checklist

vercel[bot] commented 2 months ago

@anirudh24seven is attempting to deploy a commit to the PostHog Team on Vercel.

A member of the Team first needs to authorize it.

anirudh24seven commented 2 months ago

@pauldambra I have made the requested changes but I have 2 concerns:

  1. I am not sure whether the modification I have made to the cypress test is relevant. I am not sure if I fully understood your expectation. Should I add a new command in posthog-js/cypress/support/commands.ts to test the page function?
  2. I still have not run the tests locally as I am running into setup issues related to the tests. Will update this PR once I confirm that all the unit tests and e2e tests pass.
anirudh24seven commented 2 months ago

Status of cypress tests: 2024-09-15_14-32

posthog-bot commented 1 month ago

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

anirudh24seven commented 1 month ago

@pauldambra Can you please have a look at this PR once again, if time permits?

posthog-bot commented 1 month ago

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

pauldambra commented 1 month ago

@anirudh24seven can you update with main

all looking solid to me otherwise 💪

posthog-bot commented 1 month ago

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot commented 3 weeks ago

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot commented 2 weeks ago

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.