PostHog / posthog-node

Official PostHog Node library
MIT License
21 stars 19 forks source link

Typing for `identify` method requires `event` prarameter #2

Closed DataTables closed 3 years ago

DataTables commented 4 years ago

The event parameter which is an property option of the identify method I think needs to be marked as optional, since it will default to $identify. At the moment TS is throwing an error when not given.

It might be that a second type is needed rather than just marking event as option, since it looks like it is not option for the capture method.

macobo commented 3 years ago

This is now fixed and released 1.0.6. :bow: