Add support for group analytics into posthog-node

PostHog / posthog-node

Official PostHog Node library

MIT License

21 stars 19 forks source link

Add support for group analytics into posthog-node #55

Closed macobo closed 2 years ago

macobo commented 2 years ago

Part of https://github.com/PostHog/posthog/issues/7050

Oops, actually posthog-js-lite is used there. :sweat_smile: Still a valid PR

Not sure why feature flags tests fail - seems unrelated, cc @yakkomajuri?

Integration-tested this myself as well.

Checklist

[x] Tests for new code (if applicable)
[x] TypeScript definitions (module.d.ts) updated and in sync with library exports (if applicable)

yakkomajuri commented 2 years ago

https://github.com/PostHog/posthog-node/pull/49 broke stuff

Fixed it in https://github.com/PostHog/posthog-node/commit/cd2f0f28a9575990dd9159dd43280b553bd5efca and merged master here

Would prefer to leave the review to @neilkakkar if ok - have a lot of stuff on my plate and would rather help where I might be the "best choice" e.g. Go, Ruby, PHP (not that I'm great at these, just have better context).

Everyone in our team knows JS though :D