search

PostHog / posthog-php

MIT License
18 stars 19 forks source link

TODO #2

Closed ghost closed 4 years ago

ghost commented 4 years ago

1, should handle 'host' (https://www.test.com) and 'use_ssl' => true, it becomes https://https://www.test.com 2, LibCurl the batch api endpoint is 'capture' rather than 'batch' 3, the endless loop when http code is 0

mariusandra commented 4 years ago

Hi @wppd ! Thank you for reporting these issues!

  1. Done. Now if you specify host with either http:// or https://, it'll automatically set the ssl parameter.
  2. I couldn't replicate this. It looks like /batch/ to me...?
  3. The code 0 will now be treated as a regular error. No more endless loop!
ghost commented 4 years ago

oh I was going to squeeze some time to contribute.... 2 I will test it again