search

PostHog / posthog

🦔 PostHog provides open-source product analytics, session recording, feature flagging and A/B testing that you can self-host.
https://posthog.com
Other
20.62k stars 1.23k forks source link

Leverage pipelining in redis caching in plugins #11045

Closed macobo closed 4 weeks ago

macobo commented 2 years ago

Is your feature request related to a problem?

Plugins can use cache.set and other operations. These should be as efficient as possible.

Describe the solution you'd like

Before running any processEvent/onEvent create a redis pipeline for non-read operations. Resolve that after all plugins have run.

Additional context

Inspired by a trace/looking at geoip plugin source which does a bunch of redis sets.

This needs some thinking from read-your-own-writes standpoint as well as if we'd be introducing any nasty race conditions due to parallelism that were absent before.

cc @yakkomajuri

Thank you for your feature request – we love each and every one!

posthog-bot commented 1 month ago

This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.

posthog-bot commented 4 weeks ago

This issue was closed due to lack of activity. Feel free to reopen if it's still relevant.