PostHog / posthog

🦔 PostHog provides open-source product analytics, session recording, feature flagging and A/B testing that you can self-host.
https://posthog.com
Other
21.6k stars 1.29k forks source link

Improve SAML support #13578

Open mariusandra opened 1 year ago

mariusandra commented 1 year ago

Is your feature request related to a problem?

Getting up and running with SAML can be tedious. You have to open organisation settings, and verify a domain through a DNS record. This is the easy part.

You have to open our SSO docs (SAML part), open organisation settings, and open your SAML provider's config screen. Then copy/paste keys/values between all three places. E.g. the docs ask you to copy "your instance URL + /complete/saml" to a box.

Having set up Azure AD and JumpCloud, it seems that many settings are slightly differently named between services, and our docs don't cover the difference well.

We also had an issue, where we only supported posthog-initiated SAML, but not IdP-initiated SAML (e.g. you click "log me in" in jumpcloud/okta, and expect to be logged in). This PR exposes the right RelayState variable that makes it possible to configure IdP-initiated SAML, and also exposes one of the variables you had to copy from the docs.

Describe the solution you'd like

There is so much more we could do to provide a slick experience here. For example:

Describe alternatives you've considered

Guide users as they experience issues.

Additional context

Thank you for your feature request – we love each and every one!

mariusandra commented 1 year ago

One even bigger problem: when setting up SAML incorrectly, this is all that you get when trying to log in:

image

If you're lucky enough to have access to Sentry, you might be lucky enough to learn what you configured wrong:

image

That's not slick.