PostHog / posthog

🦔 PostHog provides open-source product analytics, session recording, feature flagging and A/B testing that you can self-host.
https://posthog.com
Other
20.73k stars 1.24k forks source link

Feature flags UI improvements #14059

Open liyiy opened 1 year ago

liyiy commented 1 year ago
annikaschmid commented 1 year ago

QA of code snippet

General

Design

In the feature flags view (read/non edit), the Auto rollback is in between the release conditions and "how to implement". Did we do this on purpose? It looks a bit weird because the Auto rollback doesn't have any content. We might not need to fix this now since it's not available, but we shouldn't forget about it

Screenshot 2023-03-21 at 17 11 40

If we think of the structure of the page, this is how I see it ... X. Served Value Y. Release Conditions Z. How to implement Z.1 Payloads Z.2 Bootstrapping

The visual hierarchy currently doesn't reflect that. Z and Z.1/Z.2 are bigger than X and Y. Can we update this to match the hierarchy? If we don't have a headline smaller than what we have for "Release Conditions" at the moment, I would fall back and use it for both Z and Z.1/Z.2

Screenshot 2023-03-21 at 16 56 14

On hover and when selected, the content is currently misaligned/not centered

Screenshot 2023-03-21 at 16 59 35 Screenshot 2023-03-21 at 17 09 36

Wording

Screenshot 2023-03-21 at 17 10 33 Screenshot 2023-03-21 at 17 06 51

Side note: I love that "Check the docs" goes to the selected SDK. Nicely done :)